Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added new getUrlVariables API #68

Merged
merged 7 commits into from
Jun 7, 2022
Merged

Conversation

addb
Copy link
Contributor

@addb addb commented Jun 7, 2022

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

addb and others added 7 commits May 13, 2022 14:43
* [MOB-15817] Implemented getUrlVariables public API

* [MOB-15817] Added unit tests for getUrlVariable implementation logic

* [MOB-15817] Updated sample app with getUrlVariable public API

* [MOB-1917] Clear config

* [MOB-15817] Format fixes

* [MOB-15817] Fix javadoc

* [MOB-15817] minor bug fix and test fixes

* [MOB-15817] Add more tests

* [MOB-15817] Add tests, make minor fixes and review fixes

* [MOB-15817] Fix test and added a test to improve coverage

* [MOB-15817] Minor refactoring based on reviews

* [MOB-15817] More tests, minor refactoring and review fixes

* [MOB-15817] Review fixes

* [MOB-15817] Fix method java doc description

* [MOB-15817] Used java.net.URLEncoder instead of custom implementation. Added few tests. Also added review fixes.

* [MOB-15817] Added more tests for URL encoder

* [MOB-15817] Cleanup urlEncode helper and tests
…and api reference pages (#61)

* [MOB-15818] Added documentation directory with getting started guide and api reference pages

* [MOB-15818] Review fixes
Fetch dev branch to get the AdId implementation and documentation
@emdobrin emdobrin merged commit 0e6a09a into dev Jun 7, 2022
@emdobrin emdobrin deleted the feature/getUrlVariables branch January 9, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants